alien11689 commented on code in PR #923:
URL: https://github.com/apache/aries/pull/923#discussion_r4174357520
##########
blueprint/blueprint-authz/src/main/java/org/apache/aries/blueprint/authorization/impl/AuthorizationInterceptor.java:
##########
@@ -38,6 +39,29 @@
public class AuthorizationInterceptor implements Interceptor {
private static final Logger LOGGER =
LoggerFactory.getLogger(AuthorizationInterceptor.class);
+
+ // Subject.current() is available since Java 18, and Subject.getSubject()
is not supported anymore since Java 23
+ private static final Method SUBJECT_CURRENT = findSubjectCurrent();
+
+ private static Method findSubjectCurrent() {
Review Comment:
WDYT about using multirelease jars instead of using the reflection?
https://www.baeldung.com/maven-multi-release-jars
on the other hand it is resolved once in static so it's not the big deal
##########
blueprint/blueprint-bundle/pom.xml:
##########
@@ -111,7 +111,7 @@
<org.apache.aries.proxy.api.version>1.0.0</org.apache.aries.proxy.api.version>
<org.apache.aries.proxy.impl.version>1.0.6</org.apache.aries.proxy.impl.version>
<org.apache.aries.quiesce.api.version>1.0.0</org.apache.aries.quiesce.api.version>
-
<org.apache.aries.versioning.plugin.version>0.3.1</org.apache.aries.versioning.plugin.version>
+
<org.apache.aries.versioning.plugin.version>0.4.0</org.apache.aries.versioning.plugin.version>
Review Comment:
we can remove versioining plugin version from each pom using the newest
parent pom 3.2.0 as it picks 0.4.0 by default
https://github.com/apache/aries/blob/parent-3.2.0/parent/pom.xml#L198
##########
samples/pom.xml:
##########
@@ -445,6 +448,14 @@
</goals>
</execution>
</executions>
+ <dependencies>
+ <!-- the version used by the plugin can't read the JDK
classes of Java 9 and above -->
+ <dependency>
+ <groupId>org.apache.xbean</groupId>
+ <artifactId>xbean-finder-shaded</artifactId>
+ <version>4.30</version>
Review Comment:
the BMP is using the xbean in the correct version on trunk so we can use the
snapshot of BMP
https://github.com/apache/aries/blob/parent-3.2.0/blueprint-maven-plugin/blueprint-maven-plugin/pom.xml#L68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
