My two cents: it’s much, much more important to have a standard style (enforced automatically) than what that style is. People should come into this expecting to compromise their personal preferences.
> On Aug 28, 2018, at 10:29 AM, Bryan Cutler <cutl...@gmail.com> wrote: > > Sounds good Li. I just wanted to make sure we don't get locked into some > style choices just because google does it that way. It's a good starting > point though, so lets see how it looks applying the rules as part of > ARROW-1688 and I'll raise anything that seems like it needs some discussion. > > On Tue, Aug 28, 2018 at 6:27 AM Li Jin <ice.xell...@gmail.com> wrote: > >> Bryan, >> >> I agree that the some every google style rules might not be the best fit >> for Arrow project (e.g. import order rules). Like you said, we can use >> google style as a base line and tweak specific rules if necessary. >> >> Li >> >> On Mon, Aug 27, 2018 at 9:15 PM Bryan Cutler <cutl...@gmail.com> wrote: >> >>> Thanks for bringing this discussion up Li. I think we can use an existing >>> style guide as a starting point, but ultimately we as a community should >>> decide how to best fit it for the project. I believe we already have the >>> google checkstlye as our Java rules configuration file, but already off >> the >>> bat the import rules seem insufficient. For example, they now have a >> single >>> import group that would encompass all third-party and Arrow imports, and >>> the section of the guide about imports in your link is empty. I know a >> lot >>> of style is a matter of preference, so I would encourage anyone to follow >>> and comment in the JIRA at >>> https://issues.apache.org/jira/browse/ARROW-1688 >>> where I will be making style fixes incrementally in sub-tasks. Whatever >>> style we choose does not have to be set in stone and can always be >> changed >>> in the future, however I don't think we should point people to a >>> third-party guide as official reference. >>> >>> Thanks, >>> Bryan >>> >>> On Mon, Aug 27, 2018 at 8:09 AM Li Jin <ice.xell...@gmail.com> wrote: >>> >>>> Hi All, >>>> >>>> Bryan Cutler has started a PR to fix Java checkstyle warning (Thank you >>>> Bryan!). In my experience style is something hard to get consensus on >> due >>>> to personal preference, so I wonder if we can pick a well known style >>> guide >>>> (say google style: https://google.github.io/styleguide/javaguide.html) >>> to >>>> minimize the discussion on styles? >>>> >>>> What do other people think? >>>> >>>> Li >>>> >>> >>
