Hi Wes, sure. I opened a ticket and will do a pull request. Cheers, -- Animesh
On Fri, Nov 30, 2018 at 5:28 PM Wes McKinney <wesmck...@gmail.com> wrote: > hi Animesh -- can you link to JIRA issues about the C++ improvements > you're describing? Want to make sure this doesn't fall through the > cracks > > Thanks > Wes > On Mon, Nov 26, 2018 at 7:54 AM Antoine Pitrou <anto...@python.org> wrote: > > > > > > Hi Animesh, > > > > Le 26/11/2018 à 14:23, Animesh Trivedi a écrit : > > > > > > * C++ bitmap code can be optimized further by using the unsigned > integers > > > than "int64_t" for bitmap checks, and eliminating the kBitmap. See here > > > https://godbolt.org/z/deq0_q - compare the size of the assembly code. > And > > > the performance measurements in the blog show up to 50% performance > gains. > > > Alternatively if signed to unsigned upgrade is not possible (perhaps in > > > every language), then in the C++ code, we should use the bitmap > operations > > > directory ( `<<3` for division by 8, and ` & 0x7` for modulo by 8 > > > operation), instead of `/` and `%`. > > > > Thank you for noticing this. Switching to unsigned (and do a > > static_cast to unsigned) sounds good to me. > > > > Regards > > > > Antoine. >