In light of the severity of ARROW-4258 (https://github.com/apache/arrow/pull/3395) and some of the other rough edges in this RC, I would suggest making some fixes today and cutting an RC3. I'm revising my vote to -0
@Krisztian -- you are the RM, so it is up to you whether you want to cancel the release vote On Mon, Jan 14, 2019 at 10:50 AM Wes McKinney <wesmck...@gmail.com> wrote: > > How about using the conda-forge package? > > conda create -y -p $HOME/release-0.12-toolchain brotli -c conda-forge > export BROTLI_HOME=$HOME/release-0.12-toolchain > > > On Mon, Jan 14, 2019 at 10:46 AM Antoine Pitrou <anto...@python.org> wrote: > > > > > > Unfortunately, Ubuntu only provides shared library versions of > > Brotli but we're looking for a statically-linked brotli: > > > > make[2]: *** No rule to make target > > '/usr/lib/x86_64-linux-gnu/libbrotlidec.a', needed by > > 'release/libarrow.so.12.0.0'. Stop. > > CMakeFiles/Makefile2:2013: recipe for target > > 'src/arrow/CMakeFiles/arrow_shared.dir/all' failed > > > > > > > > > > Le 14/01/2019 à 16:46, Wes McKinney a écrit : > > > Can you set $BROTLI_HOME to unblock yourself? Since we have .deb > > > packages for Ubuntu Bionic it's an annoyance for source-builders but > > > not a deal breaker (IMHO) for the RC > > > > > > On Mon, Jan 14, 2019 at 3:24 AM Antoine Pitrou <anto...@python.org> wrote: > > >> > > >> > > >> Unfortunately I cannot validate the source release on Ubuntu 18.04, > > >> as brotli fails compiling with a internal compiler error > > >> (this is gcc 7.3.0): > > >> > > >> /tmp/arrow-0.12.0.BZuZO/apache-arrow-0.12.0/cpp/build/brotli_ep-prefix/src/brotli_ep/enc/compress_fragment.c: > > >> In function ‘BrotliCompressFragmentFastImpl13’: > > >> /tmp/arrow-0.12.0.BZuZO/apache-arrow-0.12.0/cpp/build/brotli_ep-prefix/src/brotli_ep/enc/compress_fragment.c:743:1: > > >> internal compiler error: Erreur de segmentation > > >> FOR_TABLE_BITS_(BAKE_METHOD_PARAM_) > > >> ^~~~~~~~~~~~~~~ > > >> Please submit a full bug report, > > >> with preprocessed source if appropriate. > > >> See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions. > > >> make[5]: *** [CMakeFiles/brotlienc.dir/enc/compress_fragment.c.o] Error 1 > > >> make[4]: *** [CMakeFiles/brotlienc.dir/all] Error 2 > > >> make[3]: *** [all] Error 2 > > >> > > >> > > >> Regards > > >> > > >> Antoine. > > >> > > >> > > >> Le 12/01/2019 à 20:56, Krisztián Szűcs a écrit : > > >>> Hi, > > >>> > > >>> I'd like to propose the 1st release candidate (RC2) of Apache Arrow > > >>> version > > >>> 0.12.0. This is a major release consisting of 600 resolved JIRAs [1]. > > >>> The previous RCs were not voted, because: > > >>> - RC0: the source archive didn't include required files to build > > >>> gandiva-glib > > >>> documents, also causing failed binary build for Debian Stretch [6]. > > >>> - RC1: compatibility issues with the just released pandas version > > >>> 0.24.rc1 > > >>> [8] > > >>> > > >>> This release candidate is based on commit: > > >>> 0bbaef451ae9d59799e693df9b2383808516a326 [2] > > >>> > > >>> The source release rc2 is hosted at [3]. > > >>> The binary artifacts are hosted at [4]. > > >>> The changelog is located at [5]. > > >>> > > >>> Please download, verify checksums and signatures, run the unit tests, > > >>> and vote on the release. See [7] for how to validate a release > > >>> candidate. > > >>> > > >>> The vote will be open for at least 72 hours. > > >>> > > >>> [ ] +1 Release this as Apache Arrow 0.12.0 > > >>> [ ] +0 > > >>> [ ] -1 Do not release this as Apache Arrow 0.12.0 because... > > >>> > > >>> Special thanks to @kou for helping with the uprising issues! > > >>> > > >>> - Krisztian > > >>> > > >>> [1]: > > >>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20(Resolved%2C%20Closed)%20AND%20fixVersion%20%3D%200.12.0 > > >>> [2]: > > >>> https://github.com/apache/arrow/commit/0bbaef451ae9d59799e693df9b2383808516a326 > > >>> <https://github.com/apache/arrow/tree/5ac58233936fcd2213c23adce72a79911c3f1359> > > >>> [3]: > > >>> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.12.0-rc2/ > > >>> [4]: https://bintray.com/beta/#/apache/arrow?tab=packages > > >>> [5]: > > >>> https://github.com/apache/arrow/blob/0bbaef451ae9d59799e693df9b2383808516a326/CHANGELOG.md > > >>> [6]: https://travis-ci.org/kszucs/crossbow/builds/478393330 > > >>> [7]: > > >>> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > >>> [8]: https://travis-ci.org/kszucs/crossbow/builds/478558640 > > >>>
