Thanks David! It is somewhat hard to judge, but we shouldn't release regressions in general. I can cut another RC tomorrow including your fix!
Thanks, Krisztian On Wed, Apr 21, 2021 at 12:42 AM David Li <lidav...@apache.org> wrote: > > Sorry, after some more testing I think ARROW-12487 should be a blocker > after all as it is a regression from 3.0 to 4.0. > > There's a PR up to fix it that can be backported to the 4.0 branch. > > [1]: https://issues.apache.org/jira/browse/ARROW-12487 > > Best, > David > > On 2021/04/20 21:33:28, David Li <lidav...@apache.org> wrote: > > Similarly, I'm not sure if this is blocking per se, but I found an > > issue in a new API (that was unfortunately plumbed into some > > existing APIs): https://issues.apache.org/jira/browse/ARROW-12487 > > > > This should not affect anything in verification, but if we do end up > > with an RC2, it would be nice to include the fix. > > > > Best, > > David > > > > On 2021/04/20 21:23:25, Weston Pace <weston.p...@gmail.com> wrote: > > > I'm not sure if it is blocking (and it might even be expected given > > > the current status of jfrog) but I attempted to install the CentOS 7 > > > RPM and got the following error when I ran `sudo yum update` after > > > installing the arrow repo rpm. > > > > > > https://apache.jfrog.io/artifactory/arrow/centos/7/x86_64/repodata/repomd.xml: > > > [Errno 14] HTTPS Error 404 - Not Found > > > > > > On Tue, Apr 20, 2021 at 8:49 AM Jonathan Keane <j...@ursacomputing.com> > > > wrote: > > > > > > > > I'm still working on my verification, but as part of that noticed that > > > > https://issues.apache.org/jira/browse/ARROW-12316 which we thought > > > > changed > > > > the default memory allocator didn't fully accomplish that. Nothing is > > > > broken per se, but jemalloc is still the default on macOS. I've made > > > > https://issues.apache.org/jira/browse/ARROW-12485 as a follow on if > > > > there > > > > is a need for another RC, that should definitely go in it. > > > > > > > > On Tue, Apr 20, 2021 at 2:44 AM Yibo Cai <yibo....@arm.com> wrote: > > > > > > > > > 'gandiva-decimal-test' hangs on my machine, not sure if it's a blocker > > > > > issue. > > > > > Details at https://issues.apache.org/jira/browse/ARROW-12476 > > > > > Test command "TEST_DEFAULT=0 TEST_SOURCE=1 TEST_CPP=1 > > > > > dev/release/verify-release-candidate.sh source 4.0.0 1" > > > > > > > > > > On 4/19/21 10:50 PM, Krisztián Szűcs wrote: > > > > > > Hi, > > > > > > > > > > > > I would like to propose the following release candidate (RC1) of > > > > > > Apache > > > > > > Arrow version 4.0.0. This is a release consisting of 703 > > > > > > resolved JIRA issues[1]. > > > > > > > > > > > > This release candidate is based on commit: > > > > > > 9f0082d27366f2d1985d0b5abbef7f2f07fd7e7e [2] > > > > > > > > > > > > The source release rc1 is hosted at [3]. > > > > > > The binary artifacts are hosted at [4][5][6][7]. > > > > > > The changelog is located at [8]. > > > > > > > > > > > > Please download, verify checksums and signatures, run the unit > > > > > > tests, > > > > > > and vote on the release. See [9] for how to validate a release > > > > > > candidate. > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > > > [ ] +1 Release this as Apache Arrow 4.0.0 > > > > > > [ ] +0 > > > > > > [ ] -1 Do not release this as Apache Arrow 4.0.0 because... > > > > > > > > > > > > [1]: > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%204.0.0 > > > > > > [2]: > > > > > https://github.com/apache/arrow/tree/9f0082d27366f2d1985d0b5abbef7f2f07fd7e7e > > > > > > [3]: > > > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-4.0.0-rc1 > > > > > > [4]: https://bintray.com/apache/arrow/centos-rc/4.0.0-rc1 > > > > > > [5]: https://bintray.com/apache/arrow/debian-rc/4.0.0-rc1 > > > > > > [6]: https://bintray.com/apache/arrow/python-rc/4.0.0-rc1 > > > > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/4.0.0-rc1 > > > > > > [8]: > > > > > https://github.com/apache/arrow/blob/9f0082d27366f2d1985d0b5abbef7f2f07fd7e7e/CHANGELOG.md > > > > > > [9]: > > > > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > > > > > > > > > > > > > >
