Thanks for catching that. Jest is used for running the tests and jest supports node 14.15. Could we switch to node 14.15 instead of 14.0 for this test?
On Nov 20, 2021 at 05:37:00, Benson Muite <benson_mu...@emailplus.org> wrote: > Hi, > > Tested this on AlmaLinux 8. Following steps: > > export NVM_DIR="`pwd`/.nvm" > mkdir -p $NVM_DIR > curl -o- > https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | \ > PROFILE=/dev/null bash > [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" > > nvm install --lts > npm install -g yarn > git clone https://github.com/apache/arrow > cd arrow > git checkout release-6.0.2-js > cd js > yarn --frozen-lockfile > yarn run-s clean:all lint build > yarn test > > Tests pass. > > yarn 1.22.17 > npm 8.1.0 > node 16.13.0 > > Tests also pass on > node 17.0.0 > > > Node 14 is supported until 2023, however if one tries to use Node 14, > one gets the error: > > jest@27.0.6: The engine "node" is incompatible with this module. > Expected version "^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0". Got > "14.0.0" > error Found incompatible module. > > > The current release verification script could be update to support > testing directly from a branch if this will be the point release process > in future. > > On 11/20/21 12:25 AM, Dominik Moritz wrote: > > Hi, > > > I would like to propose a patch release for Arrow JS. The release is forked > > off of maint-6.0.x and available at > > https://github.com/apache/arrow/tree/release-6.0.2-js. > > > The release contains two fixes for the js bundle: > > ARROW-14773: [JS] Fix sourcemap paths > > <https://github.com/apache/arrow/pull/11741> > > ARROW-14774: [JS] Correct package exports > > <https://github.com/apache/arrow/pull/11742> > > > [ ] +1 Release this as Apache Arrow JS 6.0.2 > > [ ] +0 > > [ ] -1 Do not release this as Apache Arrow JS 6.0.2 because... > > > Thank you, > > Dominik > > > >
