> On Sep 1, 2015, at 8:06 PM, Ian Maxon <[email protected]> wrote: > > Please vote > [ ] +1 release this package as Apache AsterixDB Hyracks 0.2.16-incubating > [ ] +0 no opinion regarding package release > [X] -1 do not release this package because …
Most things look good: - hashes ok - signature ok - DISCLAIMER ok - no unexpected binary files - all source files have headers - archive agrees with tag However I think that 1) we don’t need the NOTICE file as we don’t include source code that requires a notice and 2) we need to add the MIT license for jsplumb (https://jsplumbtoolkit.com/license), jquery (https://jquery.org/license/), and flot (https://github.com/flot/flot/blob/master/LICENSE.txt). Looking at http://www.apache.org/dev/licensing-howto.html#permissive-deps I think that we should just add those to the LICENSE file. For both of these points I wouldn’t mind to get some feedback, if I didn’t get it right :) Also, I think that it would be good to 1) include the git commit in the vote e-mail as the tag can be modified and 2) trim the list of RAT excludes to algebricks/algebricks-tests/src/test/resources/results hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/stylesheet hyracks/hyracks-dist/src/main/resources/conf hyracks/hyracks-hdfs/hyracks-hdfs-core/src/test/resources/data hyracks/hyracks-hdfs/hyracks-hdfs-core/src/test/resources/expected hyracks/hyracks-storage-am-common/src/main/resources (at least that would have covered all the files that don’t have a license in my RAT report for the unzipped source archive) 3) ensure that “mvn package" runs through with tests. For me the hyracks-integration-tests failed as apparently the data files are missing. One of the execution I saw was java.io.FileNotFoundException: data/tpch0.001/orders-part1.tbl (No such file or directory) Unfortunately, I don’t know why those are not added to the source archive. Till
