----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review180967 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java Line 181 (original), 181 (patched) <https://reviews.apache.org/r/60980/#comment256348> Do it make more sense to pass a boolean flag here to control the addition of the state to the query ? EntityProcessor will pass true whereas ClassificationProcessor will pass false - Apoorv Naik On July 19, 2017, 6:40 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60980/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 6:40 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1961 > https://issues.apache.org/jira/browse/ATLAS-1961 > > > Repository: atlas > > > Description > ------- > > - fixed NPE when search includes a free-text query & a classification that > has large number of sub-types > - fixed entity search in Solr to include state filter > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 77b2c7c2 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > 50376ef1 > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 83368c2b > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 596b43bc > > > Diff: https://reviews.apache.org/r/60980/diff/1/ > > > Testing > ------- > > - validated that the fix addressed the error cases listed above > > > Thanks, > > Madhan Neethiraj > >
