> On July 21, 2017, 3:12 a.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > > Line 56 (original), 56 (patched) > > <https://reviews.apache.org/r/60980/diff/3-4/?file=1780199#file1780199line56> > > > > Should we add all solr reserved characters here ? > > > > + - && || ! ( ) { } [ ] ^ " ~ * ? : / > > > > Otherwise overall it looks good.
For these special characters (or keywords - && ||), Solr recommends to escape with a backslash. However, we use double-quotes when value includes one of "@/ " - which serves well for our searches. This needs to be investigated further. I would suggest we take this up with Solr experts (mailing lists?). - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review181094 ----------------------------------------------------------- On July 21, 2017, 1:39 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60980/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 1:39 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1961 > https://issues.apache.org/jira/browse/ATLAS-1961 > > > Repository: atlas > > > Description > ------- > > - fixed NPE when search includes a free-text query & a classification that > has large number of sub-types > - fixed entity search in Solr to include state filter > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > a3525c93 > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 1b19a0e2 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 7950127d > > > Diff: https://reviews.apache.org/r/60980/diff/4/ > > > Testing > ------- > > - validated that the fix addressed the error cases listed above > > > Thanks, > > Madhan Neethiraj > >
