----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61541/#review182569 -----------------------------------------------------------
Fix it, then Ship it! Fix it and Ship It webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java Lines 55 (patched) <https://reviews.apache.org/r/61541/#comment258488> Do we require this GSON for this patch. - Nixon Rodrigues On Aug. 9, 2017, 8:45 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61541/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2017, 8:45 p.m.) > > > Review request for atlas, Apoorv Naik and Nixon Rodrigues. > > > Bugs: ATLAS-2037 > https://issues.apache.org/jira/browse/ATLAS-2037 > > > Repository: atlas > > > Description > ------- > > **Implementation** > Used the _doAnswer_ to be as close to regular flow as possible. This mocks > submit method and starts the _HookConsumer_ thread that was added in the > previous step. > > Verified _wakeup_ was invoked. > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 5a982bb > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > f4ec56a > > > Diff: https://reviews.apache.org/r/61541/diff/1/ > > > Testing > ------- > > **Unit tests** > Executed all unit tests for _NotificationHookConsumerTest_. > > > Thanks, > > Ashutosh Mestry > >
