-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61541/
-----------------------------------------------------------

(Updated Aug. 10, 2017, 4:18 p.m.)


Review request for atlas, Apoorv Naik and Nixon Rodrigues.


Changes
-------

Updates include:
- Addressed review comment.
- Additional unit test to handle case where consumer is stopped before starting.


Bugs: ATLAS-2037
    https://issues.apache.org/jira/browse/ATLAS-2037


Repository: atlas


Description
-------

**Implementation**
Used the _doAnswer_ to be as close to regular flow as possible. This mocks 
submit method and starts the _HookConsumer_ thread that was added in the 
previous step.

Verified _wakeup_ was invoked.


Diffs (updated)
-----

  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 5a982bb 
  
webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
 f4ec56a 


Diff: https://reviews.apache.org/r/61541/diff/2/

Changes: https://reviews.apache.org/r/61541/diff/1-2/


Testing
-------

**Unit tests**
Executed all unit tests for _NotificationHookConsumerTest_.


Thanks,

Ashutosh Mestry

Reply via email to