----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198584 -----------------------------------------------------------
distro/pom.xml Lines 258 (patched) <https://reviews.apache.org/r/65885/#comment278782> I see that you are downloading Zookeeper. Many components require zookeeper - so it may already exist on the system. I think for production you would want to run with an external Zookeeper. I suggest we allow this as a build option. I realise this jira is for the embedded Cssandra build only - but I could envisage you needing non-embedded cassandra builds as well; I thought I would suggest this here - if this is a requirement for you, you may decide you want to address this in a separate Jira. distro/pom.xml Lines 302 (patched) <https://reviews.apache.org/r/65885/#comment278783> for consistency should we have <cassandra-embedded> as well? distro/src/bin/atlas_start.py Lines 121 (patched) <https://reviews.apache.org/r/65885/#comment278784> For an embedded hbase build, it will use the hbase zk and the embeded solr. I assume this line ( and the matching stop) should not be called for the embedded hbase build (which is not using the downloaded zk). distro/src/conf/cassandra.yml Lines 22 (patched) <https://reviews.apache.org/r/65885/#comment278780> typo distro/src/conf/cassandra.yml Lines 24 (patched) <https://reviews.apache.org/r/65885/#comment278785> I suggest the install could text replace these to the correct values. Is it possible for it to refer to an environment variable with the absolute path, then the script pick up that environment variable? distro/src/conf/zookeeper/zoo.cfg Lines 20 (patched) <https://reviews.apache.org/r/65885/#comment278781> bad end of line character here and a few places below docs/src/site/twiki/InstallationSteps.twiki Lines 38 (patched) <https://reviews.apache.org/r/65885/#comment278786> We did not have to do with before this change for embedded hbase solr. I think these notes should not apply to the embedded hbase solr profile. - David Radley On March 2, 2018, 4:51 p.m., Pierre Padovani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65885/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 4:51 p.m.) > > > Review request for atlas and David Radley. > > > Bugs: ATLAS-2470 > https://issues.apache.org/jira/browse/ATLAS-2470 > > > Repository: atlas > > > Description > ------- > > This updates pom's to add the needed cassandra jars, and adds a dist profile > embedded-cassandra-solr. > > > Diffs > ----- > > distro/pom.xml 0103bef6 > distro/src/bin/atlas_config.py e6415cf4 > distro/src/bin/atlas_start.py 39be6b7c > distro/src/bin/atlas_stop.py 66edd904 > distro/src/conf/cassandra.yml PRE-CREATION > distro/src/conf/zookeeper/log4j.properties PRE-CREATION > distro/src/conf/zookeeper/zoo.cfg PRE-CREATION > distro/src/main/assemblies/standalone-package.xml 1881082e > docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 > graphdb/janus/pom.xml 143b775f > > > Diff: https://reviews.apache.org/r/65885/diff/1/ > > > Testing > ------- > > Full build with the new embedded-cassandra-solr, and testing to make sure > Atlas comes up and is functional. > > Be aware that we have been running Cassandra backed JanusGraph for months > with no issues. > > > Thanks, > > Pierre Padovani > >
