> On March 4, 2018, 11:04 a.m., David Radley wrote: > > distro/pom.xml > > Lines 258 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969111#file1969111line258> > > > > I see that you are downloading Zookeeper. Many components require > > zookeeper - so it may already exist on the system. I think for production > > you would want to run with an external Zookeeper. > > > > I suggest we allow this as a build option. I realise this jira is for > > the embedded Cssandra build only - but I could envisage you needing > > non-embedded cassandra builds as well; I thought I would suggest this here > > - if this is a requirement for you, you may decide you want to address > > this in a separate Jira.
Yes, this was meant only for the embedded side of things, which would typically only happen for a development installation or a Docker image. My intention is to address setup and config for cassandra in a production environment in the documentation. I have another task specific to updating the documentation around this. My hope was to get this merged to master first, then I can get the Dockerfile built out that supports this configuration in another task. > On March 4, 2018, 11:04 a.m., David Radley wrote: > > distro/pom.xml > > Lines 302 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969111#file1969111line302> > > > > for consistency should we have <cassandra-embedded> as well? You cannot just have cassandra without a solr/elasticsearch install unless you are using DSE (the Datastax Enterprise with integrates with solr). Based on cursory reading over on JanusGraph, they do not recommend production deployments of JanusGraph with Cassandra embedded as the performance profiles are not entirely predictable. Again I would address this in the main documentation task. > On March 4, 2018, 11:04 a.m., David Radley wrote: > > distro/src/bin/atlas_start.py > > Lines 121 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969113#file1969113line121> > > > > For an embedded hbase build, it will use the hbase zk and the embeded > > solr. I assume this line ( and the matching stop) should not be called for > > the embedded hbase build (which is not using the downloaded zk). I could swear I tested this, and it required I spin up a zookeeper to get it to work. I just reset to master and retested (after fixing the atlas_config.py) and it worked without a local ZK start. So I'll remove this from the profile. > On March 4, 2018, 11:04 a.m., David Radley wrote: > > docs/src/site/twiki/InstallationSteps.twiki > > Lines 38 (patched) > > <https://reviews.apache.org/r/65885/diff/1/?file=1969119#file1969119line38> > > > > We did not have to do with before this change for embedded hbase solr. > > I think these notes should not apply to the embedded hbase solr profile. Yep, as stated before I'll remove it, and find a way to only do it for a cassandra deploy. - Pierre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65885/#review198584 ----------------------------------------------------------- On March 2, 2018, 4:51 p.m., Pierre Padovani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65885/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 4:51 p.m.) > > > Review request for atlas and David Radley. > > > Bugs: ATLAS-2470 > https://issues.apache.org/jira/browse/ATLAS-2470 > > > Repository: atlas > > > Description > ------- > > This updates pom's to add the needed cassandra jars, and adds a dist profile > embedded-cassandra-solr. > > > Diffs > ----- > > distro/pom.xml 0103bef6 > distro/src/bin/atlas_config.py e6415cf4 > distro/src/bin/atlas_start.py 39be6b7c > distro/src/bin/atlas_stop.py 66edd904 > distro/src/conf/cassandra.yml PRE-CREATION > distro/src/conf/zookeeper/log4j.properties PRE-CREATION > distro/src/conf/zookeeper/zoo.cfg PRE-CREATION > distro/src/main/assemblies/standalone-package.xml 1881082e > docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 > graphdb/janus/pom.xml 143b775f > > > Diff: https://reviews.apache.org/r/65885/diff/1/ > > > Testing > ------- > > Full build with the new embedded-cassandra-solr, and testing to make sure > Atlas comes up and is functional. > > Be aware that we have been running Cassandra backed JanusGraph for months > with no issues. > > > Thanks, > > Pierre Padovani > >
