-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 14, 2018, 12:02 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
-------

Updates include:
- Addressed review comments.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
9dba1c06fa5548470056cf8cf095f3d2744650b0 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 381191986df81d691e2598d4760d7999344dc630 


Diff: https://reviews.apache.org/r/68312/diff/4/

Changes: https://reviews.apache.org/r/68312/diff/3-4/


Testing
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.

**Functional tests**
- Quick Start
- Entity creation via REST APIs.
- Entity creation via APIs.


File Attachments
----------------

rdbms-db.json
  
https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  
https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Reply via email to