-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68312/
-----------------------------------------------------------

(Updated Aug. 14, 2018, 10:50 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
-------

Updates include:
- Handled delete from list attribute.
- Handled delete from map attribute.
- Additional unit tests to verify delete and udpate in collection.


Bugs: ATLAS-2813
    https://issues.apache.org/jira/browse/ATLAS-2813


Repository: atlas


Description
-------

**Approach**
- Add _options_ field to _AtlasAttributeDef_.
- Implement support in _AtlasStructDefStore_.
- Update _EntityGraphMapper_
- Update _EntityGraphRetriever_
- Supports array of objects and objects.

**Usage**
See attached JSON.


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java
 b32c09255 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 381191986 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 81b553e6e 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftReferenceTest.java
 856f38347 


Diff: https://reviews.apache.org/r/68312/diff/5/

Changes: https://reviews.apache.org/r/68312/diff/4-5/


Testing
-------

**Unit tests**
Tests verify object, array<object>, map<string,object> cases.

**Functional tests**
- Quick Start
- Entity creation via REST APIs.
- Entity creation via APIs.


File Attachments
----------------

rdbms-db.json
  
https://reviews.apache.org/media/uploaded/files/2018/08/13/ded0e80a-bc59-4dc4-ba74-d971c7af8aef__rdbms-db.json
typesDef-soft-ref.json
  
https://reviews.apache.org/media/uploaded/files/2018/08/13/e7c79e63-d08b-41ff-97ef-85389a6d63e3__typesDef-soft-ref.json


Thanks,

Ashutosh Mestry

Reply via email to