----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70333/#review214175 -----------------------------------------------------------
Fix it, then Ship it! graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java Lines 213 (patched) <https://reviews.apache.org/r/70333/#comment300372> getOpenTransactions() method doesn't seem to be used. If this is not needed, please consider reverting changes in AtlasGraph.java and AtlasJanusGraph.java. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java Lines 574 (patched) <https://reviews.apache.org/r/70333/#comment300373> Vertices returned from this method will be used after the transaction is committed here. Please make sure to verify that this works; in some frameworks (like ORM) changes to the retrieved object are honored only in the scope of the transaction in which they are retrievd. - Madhan Neethiraj On March 28, 2019, 7:30 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70333/ > ----------------------------------------------------------- > > (Updated March 28, 2019, 7:30 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, > and Nixon Rodrigues. > > > Bugs: ATLAS-3104 > https://issues.apache.org/jira/browse/ATLAS-3104 > > > Repository: atlas > > > Description > ------- > > stale transaction alerts have been seen in atlas logs after the java patch > handler. > > Need to close transaction after graph access. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java > 09eab2864 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java > 93284140c > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasJavaPatchHandler.java > 470ff1054 > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatchHandler.java > 0c65ef169 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > eac2a03aa > > > Diff: https://reviews.apache.org/r/70333/diff/1/ > > > Testing > ------- > > No longer see stale transaction alerts in the log. > > > Thanks, > > Sarath Subramanian > >
