> On March 28, 2019, 10:05 a.m., Ashutosh Mestry wrote: > > Consider this approach. Do all the processing at AtlasJanusGraph level. > > That way you will have complete control of batching, commits, etc.
will create a new JIRA to batch the commits and parallel process. Will need to benchmark the current approach before perf enhancement. > On March 28, 2019, 10:05 a.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > > Lines 515 (patched) > > <https://reviews.apache.org/r/70333/diff/1/?file=2135861#file2135861line515> > > > > This will cause a large commit to happen. Consider batching. Optimal is > > 3000 based on my experiments. same as above - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70333/#review214180 ----------------------------------------------------------- On March 28, 2019, 2:01 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70333/ > ----------------------------------------------------------- > > (Updated March 28, 2019, 2:01 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, > and Nixon Rodrigues. > > > Bugs: ATLAS-3104 > https://issues.apache.org/jira/browse/ATLAS-3104 > > > Repository: atlas > > > Description > ------- > > stale transaction alerts have been seen in atlas logs after the java patch > handler. > > Need to close transaction after graph access. > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java > 09eab2864 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java > 93284140c > > repository/src/main/java/org/apache/atlas/repository/patches/AtlasJavaPatchHandler.java > 470ff1054 > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatchHandler.java > 0c65ef169 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > eac2a03aa > > > Diff: https://reviews.apache.org/r/70333/diff/2/ > > > Testing > ------- > > No longer see stale transaction alerts in the log. > > > Thanks, > > Sarath Subramanian > >
