> On May 7, 2019, 8:16 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java > > Lines 182 (patched) > > <https://reviews.apache.org/r/70599/diff/2/?file=2143593#file2143593line182> > > > > consider having delimited separated values - > > guid1:guid2:guid3 instead of braces ([]);
This is storing in JSON format. The intent was that we would be able to retrieve this at some point in future. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70599/#review215093 ----------------------------------------------------------- On May 6, 2019, 11:34 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70599/ > ----------------------------------------------------------- > > (Updated May 6, 2019, 11:34 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath > Subramanian. > > > Bugs: ATLAS-3193 > https://issues.apache.org/jira/browse/ATLAS-3193 > > > Repository: atlas > > > Description > ------- > > **Background** > Please look at bug description. > > **Approach** > _ExportService_: Refactor to extract starting entity logic in a separate > reusable class. > (New) _StartEntityFetchByExportRequest_: Extracted logic for fetching start > entity. > _BulkImporterImpl_: Handle _AtlasSchemaViolation_ to update guid of existing > entity. Uses start entity logic (from _StartEntityFetchByExportRequest_ to > check and fetch existing entities). > _GraphBackedSearchIndexer_: Additional property to index. > > **CURL** > > Import: > ``` > curl -X POST -u admin:passW0rd -H "Content-Type: multipart/form-data" -H > "Cache-Control: no-cache" -F data=@./stocks.zip > http://localhost:21000/api/atlas/admin/import > ``` > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 5055a0426 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 1cfa202a9 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 62298f9f1 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java > a52c3f986 > > repository/src/main/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequest.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java > dc8bd19df > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 14f991697 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > a1d6cef5c > > repository/src/test/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequestTest.java > PRE-CREATION > > tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java > 91ff89a00 > > > Diff: https://reviews.apache.org/r/70599/diff/2/ > > > Testing > ------- > > **Unit tests** > New tests added. > > **Functional tests** > Existing export and import flow via CURL calls. > > > Thanks, > > Ashutosh Mestry > >
