-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70599/
-----------------------------------------------------------
(Updated May 7, 2019, 9:19 p.m.)
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath
Subramanian.
Changes
-------
Updates include:
- Addressed review comments.
- Added pre-commit build details.
Bugs: ATLAS-3193
https://issues.apache.org/jira/browse/ATLAS-3193
Repository: atlas
Description
-------
**Background**
Please look at bug description.
**Approach**
_ExportService_: Refactor to extract starting entity logic in a separate
reusable class.
(New) _StartEntityFetchByExportRequest_: Extracted logic for fetching start
entity.
_BulkImporterImpl_: Handle _AtlasSchemaViolation_ to update guid of existing
entity. Uses start entity logic (from _StartEntityFetchByExportRequest_ to
check and fetch existing entities).
_GraphBackedSearchIndexer_: Additional property to index.
**CURL**
Import:
```
curl -X POST -u admin:passW0rd -H "Content-Type: multipart/form-data" -H
"Cache-Control: no-cache" -F data=@./stocks.zip
http://localhost:21000/api/atlas/admin/import
```
Diffs (updated)
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 5055a0426
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
1cfa202a9
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
62298f9f1
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
a52c3f986
repository/src/main/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequest.java
PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
dc8bd19df
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
14f991697
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
a1d6cef5c
repository/src/test/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequestTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/70599/diff/3/
Changes: https://reviews.apache.org/r/70599/diff/2-3/
Testing (updated)
-------
**Unit tests**
New tests added.
**Functional tests**
Existing export and import flow via CURL calls.
**Pre-commit**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1081/
Thanks,
Ashutosh Mestry
