> On Oct. 22, 2019, 5:43 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 46 (patched) > > <https://reviews.apache.org/r/71619/diff/6/?file=2169782#file2169782line46> > > > > is it different from Name? > > Sridhar K wrote: > We have name attribute already. Can we we use it instead?
good point. removed it. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218328 ----------------------------------------------------------- On Oct. 22, 2019, 3:42 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2019, 3:42 p.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/4000-MachineLearning/4010-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/6/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
