----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218332 -----------------------------------------------------------
addons/models/4000-MachineLearning/4010-ml_model.json Lines 123 (patched) <https://reviews.apache.org/r/71619/#comment305998> I am not the right person for this comment. But, this name looks confusing....is it a tag or image url? addons/models/4000-MachineLearning/4010-ml_model.json Lines 269 (patched) <https://reviews.apache.org/r/71619/#comment305999> I am wondering if we should have a first class entity called "User" defined in base model and you have ml_user extend from it. what do you say? - Sridhar K On Oct. 22, 2019, 6:17 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2019, 6:17 p.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/4000-MachineLearning/4010-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/7/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
