-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72127/
-----------------------------------------------------------

(Updated Feb. 13, 2020, 9:49 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
Subramanian.


Bugs: ATLAS-3615
    https://issues.apache.org/jira/browse/ATLAS-3615


Repository: atlas


Description
-------

Issues:
1) Combination of typeName:_ALL_ENTITY_TYPES and classification doesn't return 
result
Why? As _ALL_ENTITY_TYPES value is assigned as [* TO *] results show up when 
searched from solr but not from graphdb
2) Combination of typeName:_ALL_ENTITY_TYPES, classification, 
query(SearchByText) doesn't return result
Why? result from solr, thru "/freetext" is correct, but onsearching if resulted 
entitytype is in typeAndSubtypes of given entityType, it breaks because 
typeAndSubTypes of _ALL_ENTITY_TYPES is [* TO *]


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
b5606d046 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
353411363 


Diff: https://reviews.apache.org/r/72127/diff/2/

Changes: https://reviews.apache.org/r/72127/diff/1-2/


Testing
-------

For issue1:
1) tested with values _ALL_ENTITY_TYPES + EntityFilter + classification -> 
result fetches from gremlin and shows up correct result
2) tested with values _ALL_ENTITY_TYPES + classification -> result fetches from 
gremlin and shows up correct result

For issue2:
1) tested with values _ALL_ENTITY_TYPES + classification + query(SearchByText) 
-> shows up correct result


Thanks,

Pinal Shah

Reply via email to