----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72127/#review219622 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Line 148 (original), 149 (patched) <https://reviews.apache.org/r/72127/#comment307824> consider combining if condition in line 150 into 140: if (!typeSearchByIndex && !isEntityRootType()) repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Lines 349 (patched) <https://reviews.apache.org/r/72127/#comment307825> nit: remove new line - Sarath Subramanian On Feb. 18, 2020, 3:57 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72127/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2020, 3:57 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3615 > https://issues.apache.org/jira/browse/ATLAS-3615 > > > Repository: atlas > > > Description > ------- > > Issues: > 1) Combination of typeName:_ALL_ENTITY_TYPES and classification doesn't > return result > Why? As _ALL_ENTITY_TYPES value is assigned as [* TO *] results show up when > searched from solr but not from graphdb > > 2) Combination of typeName:_ALL_ENTITY_TYPES, classification, > query(SearchByText) doesn't return result > Why? result from solr, thru "/freetext" is correct, but onsearching if > resulted entitytype is in typeAndSubtypes of given entityType, it breaks > because typeAndSubTypes of _ALL_ENTITY_TYPES is [* TO *] > > 3) Combination of typeName, classification:_ALL_CLASSIFICATION_TYPES doesn't > return result > > 4) Combination of typeName:_ALL_ENTITY_TYPES, > classification:_ALL_CLASSIFICATION_TYPES, query(SearchByText) doesn't return > correct result > why? query formed with above combination in solr /freetext is 'SAMPLEQUERY' > AND [* TO *] AND [* TO *] > > 5) Combination of classification:_ALL_CLASSIFICATION_TYPES and > classificationFilter doesn't return correct result > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > c0a5a46dd > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > b5606d046 > > repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java > d628f1352 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 353411363 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 8c17a9044 > > > Diff: https://reviews.apache.org/r/72127/diff/3/ > > > Testing > ------- > > For issue1: > 1) tested with values _ALL_ENTITY_TYPES + EntityFilter + classification -> > result fetches from gremlin and shows up correct result > 2) tested with values _ALL_ENTITY_TYPES + classification -> result fetches > from gremlin and shows up correct result > > For issue2: > 1) tested with values _ALL_ENTITY_TYPES + classification + > query(SearchByText) -> shows up correct result > > > Thanks, > > Pinal Shah > >
