----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/#review220274 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java Lines 185 (patched) <https://reviews.apache.org/r/72270/#comment308609> - why is it necessary to send AtlasBusinessMetadataType.AtlasBusinessAttribute (attribute-type) list to notifications? If it is send names of attributes added/updated/deleted, consider using a Set<String> type argument. - updates to business attributes is covered by a single permission - AtlasPrivilege.ENTITY_UPDATE_BUSINESS_METADATA. I suggest to use only one audit action - BUSINESS_ATTRIBUTES_UPDATE. The audit data should include name & value of all business attributes that were added/updated/deleted; for deleted attributes, the value should be null. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 608 (patched) <https://reviews.apache.org/r/72270/#comment308610> This creates one audit entry for each attribute; this is not necessary/useful. I suggest to create a single audit that includes all added/updated/removed business-attributes - similar to add/update/remove of classifications. - Madhan Neethiraj On April 9, 2020, 8:22 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72270/ > ----------------------------------------------------------- > > (Updated April 9, 2020, 8:22 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3689 > https://issues.apache.org/jira/browse/ATLAS-3689 > > > Repository: atlas > > > Description > ------- > > Add audits entries when Namespace Attributes are added/updated/deleted to an > entity > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java > 2394a12 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > 9301e21 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > cab4e1e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java > 00c0114 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 0d5b631 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java > c4dc5a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java > 2943ea9 > > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java > 6d64fec > > > Diff: https://reviews.apache.org/r/72270/diff/4/ > > > Testing > ------- > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console > > Basic testing is done. > > > Thanks, > > Mandar Ambawane > >
