----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/#review220289 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java Lines 184 (patched) <https://reviews.apache.org/r/72270/#comment308620> - onBusinessMetadataAttributeUpdated() => onBusinessAttributesUpdated - bmAttrValueMap => updatedBusinessAttributes intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java Lines 54 (patched) <https://reviews.apache.org/r/72270/#comment308622> BUSINESS_METADATA_ATTRIBUTE_ADD and BUSINESS_METADATA_ATTRIBUTE_DELETE are not used. Please review and remove. repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java Lines 603 (patched) <https://reviews.apache.org/r/72270/#comment308621> bmAttrValueMap => updatedBusinessAttributes repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java Lines 768 (patched) <https://reviews.apache.org/r/72270/#comment308623> bmAttrValueMap => updatedBusinessAttributes repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 421 (patched) <https://reviews.apache.org/r/72270/#comment308624> - please move 'private' methods towards end of the file i.e. after all public and protected methods - is 'action' argument needed anymore, given BUSINESS_METADATA_ATTRIBUTE_UPDATE is the only action supported for business-attributes? - since 'action' is not needed, please update 'bmAttributeActionMap': from: Map<String, Map<EntityAuditEventV2.EntityAuditActionV2, List<AtlasBusinessAttribute>>> bmAttributeActionMap to: Map<String, Map<String, Object> updatedBusinessAttributes repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java Lines 529 (patched) <https://reviews.apache.org/r/72270/#comment308626> Consider sending entityGuid, instead of retrieving entity here - similar to notificaitons for label updates. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java Lines 56 (patched) <https://reviews.apache.org/r/72270/#comment308625> - onBusinessMetadataAttributeUpdatedToEntity() ==> onBusinessAttributesUpdated() - bmAttrValueMap => updatedBusinessAttributes - Madhan Neethiraj On April 11, 2020, 11:57 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72270/ > ----------------------------------------------------------- > > (Updated April 11, 2020, 11:57 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3689 > https://issues.apache.org/jira/browse/ATLAS-3689 > > > Repository: atlas > > > Description > ------- > > Add audits entries when Namespace Attributes are added/updated/deleted to an > entity > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java > 2394a12 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > 9301e21 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > cab4e1e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java > 00c0114 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 8819688 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java > c4dc5a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java > 2943ea9 > > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java > 6d64fec > > > Diff: https://reviews.apache.org/r/72270/diff/5/ > > > Testing > ------- > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console > > Basic testing is done. > > > Thanks, > > Mandar Ambawane > >
