> On May 8, 2020, 4:48 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > > Line 195 (original), 195 (patched) > > <https://reviews.apache.org/r/72486/diff/1/?file=2231049#file2231049line195> > > > > Prefer GraphTraversal over gremlin. GraphTraversal is order of > > magnitude faster than germlin.
Sure Ashutosh, I will update this with GraphTraversal, but i think i should create new JIRA for it. Thanks for reviewing. - Pinal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72486/#review220698 ----------------------------------------------------------- On May 8, 2020, 11:21 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72486/ > ----------------------------------------------------------- > > (Updated May 8, 2020, 11:21 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3780 > https://issues.apache.org/jira/browse/ATLAS-3780 > > > Repository: atlas > > > Description > ------- > > We are having 'State' Attribute for Status i.e ACTIVE and DELETED. > Whenever Entity is Deleted,'state' is always ACTIVE for Classification > vertices but 'entityState' gets reflected as 'DELETED'. > > For this UI, needs to handle '_entityStatus' as enum and whenever DELETED is > selected, showHistoricalEntities needs to be true. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 4d0179c44 > intg/src/main/java/org/apache/atlas/type/Constants.java 3fc13056e > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 74c088c0e > > > Diff: https://reviews.apache.org/r/72486/diff/1/ > > > Testing > ------- > > Manually tested > > > Thanks, > > Pinal Shah > >
