----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72486/#review220930 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java Lines 336 (patched) <https://reviews.apache.org/r/72486/#comment309647> change string literal "ACTIVE" to AtlasEntity.Status.ACTIVE.name() - Sarath Subramanian On May 11, 2020, 7:01 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72486/ > ----------------------------------------------------------- > > (Updated May 11, 2020, 7:01 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3780 > https://issues.apache.org/jira/browse/ATLAS-3780 > > > Repository: atlas > > > Description > ------- > > We are having 'State' Attribute for Status i.e ACTIVE and DELETED. > Whenever Entity is Deleted,'state' is always ACTIVE for Classification > vertices but 'entityState' gets reflected as 'DELETED'. > > For this UI, needs to handle '_entityStatus' as enum and whenever DELETED is > selected, showHistoricalEntities needs to be true. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 4d0179c44 > intg/src/main/java/org/apache/atlas/type/Constants.java 3fc13056e > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 74c088c0e > > > Diff: https://reviews.apache.org/r/72486/diff/1/ > > > Testing > ------- > > Manually tested > > > Thanks, > > Pinal Shah > >
