> On July 21, 2020, 8:38 p.m., Ashutosh Mestry wrote: > > Here's what I have tried so far: > > - Concurrent entity creation using my own test rig. This creates entities > > concurrently but it does not allow for entity with same qualifiedName to be > > created by different workers. > > - Ingest via Kafka queue. This is to verify that there is not performance > > degradation. > > > > So far results are positive. I did not obseve any performance or impact on > > accuracy. > > > > Yet to try: > > - Migration from 0.8 to latest. > > - Migration import using ZipDirect format. > > Madhan Neethiraj wrote: > Ashutosh - what is the behavior seen in case of simultaneous attempts to > entity an entity? Do all but 1 attempt fail?
Please see my comment below. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221296 ----------------------------------------------------------- On July 20, 2020, 9:48 p.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72695/ > ----------------------------------------------------------- > > (Updated July 20, 2020, 9:48 p.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > Optional configuration to support locks on JanusGraph to ensure data > consitency. > > JanusGraph is eventually consistent by default which is efficient but results > in duplicates when race condition occurs. > > > Reference to jira > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398 > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java > fca789027 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > 6ef9cb76c > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > 35004157f > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java > 5cd55093e > intg/src/main/java/org/apache/atlas/ApplicationProperties.java e662c8fae > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > e35f3594f > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > 5a9ac2abe > > repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java > d3111f110 > > > Diff: https://reviews.apache.org/r/72695/diff/1/ > > > Testing > ------- > > Not possible to reproduce the error on local machine. Enable locking on our > dev env and have not introduce any regression. > > > Thanks, > > Damian Warszawski > >