> On July 23, 2020, 4:52 a.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Lines 44 (patched) > > <https://reviews.apache.org/r/72695/diff/1/?file=2236038#file2236038line44> > > > > I suggest use AtlasConfiguration for this. Also, I think this should be > > true by default. > > Damian Warszawski wrote: > Great simplification. Thanks Ashutosh.
Not sure if that should be true by default as long as not having a proper benchmarks how the performance is degradated. - Damian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221323 ----------------------------------------------------------- On July 24, 2020, 8:23 a.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72695/ > ----------------------------------------------------------- > > (Updated July 24, 2020, 8:23 a.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > Optional configuration to support locks on JanusGraph to ensure data > consitency. > > JanusGraph is eventually consistent by default which is efficient but results > in duplicates when race condition occurs. > > > Reference to jira > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398 > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > 6ef9cb76c > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca01 > > > Diff: https://reviews.apache.org/r/72695/diff/2/ > > > Testing > ------- > > Not possible to reproduce the error on local machine. Enable locking on our > dev env and have not introduce any regression. > > > Thanks, > > Damian Warszawski > >
