----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221368 -----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java Lines 50 (patched) <https://reviews.apache.org/r/72695/#comment310257> lockEnabled => CONSISTENCY_LOCK_ENABLED graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java Line 271 (original), 267 (patched) <https://reviews.apache.org/r/72695/#comment310256> call to indexBuilder.unique() shouldn't require lockEnabled=true. Please retain current if condition: "(lockEnabled && isUnique)" => "(isUnique)" intg/src/main/java/org/apache/atlas/AtlasConfiguration.java Lines 75 (patched) <https://reviews.apache.org/r/72695/#comment310255> STORAGE_LOCK_ENABLED("atlas.graph.storage.lock.enabled") => STORAGE_CONSISTENCY_LOCK_ENABLED("atlas.graph.storage.consistency-lock.enabled") - Madhan Neethiraj On July 24, 2020, 8:23 a.m., Damian Warszawski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72695/ > ----------------------------------------------------------- > > (Updated July 24, 2020, 8:23 a.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > Optional configuration to support locks on JanusGraph to ensure data > consitency. > > JanusGraph is eventually consistent by default which is efficient but results > in duplicates when race condition occurs. > > > Reference to jira > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398 > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java > 6ef9cb76c > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca01 > > > Diff: https://reviews.apache.org/r/72695/diff/2/ > > > Testing > ------- > > Not possible to reproduce the error on local machine. Enable locking on our > dev env and have not introduce any regression. > > > Thanks, > > Damian Warszawski > >
