-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73166/#review222545
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/query/GremlinClause.java
Line 72 (original), 72 (patched)
<https://reviews.apache.org/r/73166/#comment311646>

    Purpose of adding 'and(.in)' was to avoid traversing to the edge and then 
end vertex


- Pinal Shah


On Feb. 1, 2021, 5:20 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73166/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2021, 5:20 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4109
>     https://issues.apache.org/jira/browse/ATLAS-4109
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Replaced _or_ with _where_ for simplicity.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> b7e5330ce 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  a7b05fd88 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 0e8af186d 
> 
> 
> Diff: https://reviews.apache.org/r/73166/diff/1/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> - Existing tests run.
> - Updated _GremlinQueryComposer_ to include the new clause.
> 
> **PC-build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Reply via email to