----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73166/#review222578 -----------------------------------------------------------
Ship it! Ship It! - Pinal Shah On Feb. 3, 2021, 9:46 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73166/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2021, 9:46 p.m.) > > > Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian. > > > Bugs: ATLAS-4109 > https://issues.apache.org/jira/browse/ATLAS-4109 > > > Repository: atlas > > > Description > ------- > > Replaced _or_ with _where_ for simplicity. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/GremlinClause.java > b7e5330ce > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > 156a65ccb > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 3594e2f34 > > > Diff: https://reviews.apache.org/r/73166/diff/2/ > > > Testing > ------- > > **Unit tests** > - Existing tests run. > - Updated _GremlinQueryComposer_ to include the new clause. > > **PC-build** > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/ > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/366/ > > > Thanks, > > Ashutosh Mestry > >
