----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73502/#review223307 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java Line 47 (original), 47 (patched) <https://reviews.apache.org/r/73502/#comment312397> Retain imports. (If using IntelliJ, change default setting.) repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java Line 56 (original), 51 (patched) <https://reviews.apache.org/r/73502/#comment312394> nit: Retain individual imports. repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java Lines 82 (patched) <https://reviews.apache.org/r/73502/#comment312395> Good! repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java Lines 91 (patched) <https://reviews.apache.org/r/73502/#comment312396> Consider replacing string with the error message mentioned in the AtlasErrorCode. - Ashutosh Mestry On Aug. 4, 2021, 2:11 p.m., Shraddha Pardeshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73502/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2021, 2:11 p.m.) > > > Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and > Pinal Shah. > > > Bugs: ATLAS-3917 > https://issues.apache.org/jira/browse/ATLAS-3917 > > > Repository: atlas > > > Description > ------- > > -Actual Behaviour : While deleting parent tag if the tag is not associated > with any entity shows this message- "Given type {0} has reference." > -Expected Result: There should be tag name instead of {0} > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java > b9d41bbba > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java > 3242a33ad > > > Diff: https://reviews.apache.org/r/73502/diff/1/ > > > Testing > ------- > > -Manual testing done on local server > > -Test case added. > > PC - > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console > > > Thanks, > > Shraddha Pardeshi > >
