----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73502/#review223344 -----------------------------------------------------------
Fix it, then Ship it! Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java Line 273 (original), 273 (patched) <https://reviews.apache.org/r/73502/#comment312421> move #273 inside if condition (#274), so that name will be fetched only when exception is to be thrown. - Nikhil Bonte On Aug. 5, 2021, 12:46 p.m., Shraddha Pardeshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73502/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2021, 12:46 p.m.) > > > Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and > Pinal Shah. > > > Bugs: ATLAS-3917 > https://issues.apache.org/jira/browse/ATLAS-3917 > > > Repository: atlas > > > Description > ------- > > -Actual Behaviour : While deleting parent tag if the tag is not associated > with any entity shows this message- "Given type {0} has reference." > -Expected Result: There should be tag name instead of {0} > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java > b9d41bbba > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java > 3242a33ad > > > Diff: https://reviews.apache.org/r/73502/diff/2/ > > > Testing > ------- > > -Manual testing done on local server > > -Test case added. > > PC - > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console > > > Thanks, > > Shraddha Pardeshi > >
