> On Sept. 29, 2021, 6:20 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceDirect.java > > Lines 260 (patched) > > <https://reviews.apache.org/r/73585/diff/2/?file=2253180#file2253180line260> > > > > I think this change is not necessary given that the input will always > > have a typeDefinition.
This is needed as if someone forget to pass the typedef then we should not throw NPE. - Sidharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73585/#review223548 ----------------------------------------------------------- On Oct. 5, 2021, 11:30 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73585/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2021, 11:30 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4425 > https://issues.apache.org/jira/browse/ATLAS-4425 > > > Repository: atlas > > > Description > ------- > > ATLAS-442: Added support for Migration import to run on a directory with > multip[le zip files > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceDirect.java > 04342fa52 > > repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java > d56261f78 > > > Diff: https://reviews.apache.org/r/73585/diff/3/ > > > Testing > ------- > > Manually tested with multiple zip files at a location which was imported > successfully. > > > Thanks, > > Sidharth Mishra > >
