----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73585/#review223590 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java Lines 71 (patched) <https://reviews.apache.org/r/73585/#comment312694> add a comment about fileName can support wildcards. fileNameMightBeWithWildcard => fileName repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java Lines 74 (patched) <https://reviews.apache.org/r/73585/#comment312698> consider moving this method to create archive directory inside getAllFilesToImport(); The parent File objects are already constructed in getAllFilesToImport(). repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java Lines 112 (patched) <https://reviews.apache.org/r/73585/#comment312695> Move line 109 and 112 inside 'if' block (after line 115). Construct this object only after checking if it is a valid directory. also move line 117 inside 'if' block (after line 119) repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java Lines 122 (patched) <https://reviews.apache.org/r/73585/#comment312696> eachFile => importFile repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java Lines 123 (patched) <https://reviews.apache.org/r/73585/#comment312697> extract to method to check - isValidImportFile(importFile) repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java Lines 162 (patched) <https://reviews.apache.org/r/73585/#comment312699> check if you have write/move permission on the destination archive dir as well (newFile) - Sarath Subramanian On Oct. 5, 2021, 4:30 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73585/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2021, 4:30 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4425 > https://issues.apache.org/jira/browse/ATLAS-4425 > > > Repository: atlas > > > Description > ------- > > ATLAS-442: Added support for Migration import to run on a directory with > multip[le zip files > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceDirect.java > 04342fa52 > > repository/src/main/java/org/apache/atlas/repository/migration/ZipFileMigrationImporter.java > d56261f78 > > > Diff: https://reviews.apache.org/r/73585/diff/3/ > > > Testing > ------- > > Manually tested with multiple zip files at a location which was imported > successfully. > > > Thanks, > > Sidharth Mishra > >
