----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73731/#review224106 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Line 128 (original), 133 (patched) <https://reviews.apache.org/r/73731/#comment313057> Can we use atlasGlossaryDTO.from(glossaryEntity) and update "from" method to set the displayText instead of implementing new methods to avaoid duplicate code. repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Lines 1335 (patched) <https://reviews.apache.org/r/73731/#comment313058> categoryObjectId.getRelationshipAttributes().getAttribute("parentCategoryGuid") can be used instead of getting all attributes and null check. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Lines 1554 (patched) <https://reviews.apache.org/r/73731/#comment313059> ret.getRelationshipAttributes().setAttribute("parentCategoryGuid", parentCategoryGuid) can be used which will handle to create attributes map if none present. - Radhika Kundam On Feb. 9, 2022, 8:54 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73731/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2022, 8:54 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Radhika Kundam, > and Sarath Subramanian. > > > Bugs: ATLAS-4495 > https://issues.apache.org/jira/browse/ATLAS-4495 > > > Repository: atlas > > > Description > ------- > > It is observed that, due to existing framework Glossary GET api takes longer > time. > > This patch avoids the unnecessary db calls and improve the performance when > there is large number of data associated with the Glossary (say 10K terms or > categories) > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > f81b53854 > repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java > f902b2afb > > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java > c525bdb99 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 794847555 > > > Diff: https://reviews.apache.org/r/73731/diff/2/ > > > Testing > ------- > > Manual testing is done. > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1009/consoleFull > > > Thanks, > > Mandar Ambawane > >
