----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73731/ -----------------------------------------------------------
(Updated April 28, 2022, 7:43 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Radhika Kundam, and Sarath Subramanian. Bugs: ATLAS-4495 https://issues.apache.org/jira/browse/ATLAS-4495 Repository: atlas Description ------- It is observed that, due to existing framework Glossary GET api takes longer time. This patch avoids the unnecessary db calls and improve the performance when there is large number of data associated with the Glossary (say 10K terms or categories) Diffs ----- repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java f81b53854 repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java f902b2afb repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java bee88c61f repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 9671df994 Diff: https://reviews.apache.org/r/73731/diff/4/ Testing (updated) ------- Manual testing is done. PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1009/consoleFull PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1049/consoleFull PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1053/ There are total 11K Terms distributed among 11 Glossaries. For Glossary GET api without any performance changes it took: 1. 180 seconds 2. 168.814 seconds 3. 169.237 seconds AVERAGE: 172.683 seconds For Glossary GET api with performance changes it took: 1. 45 seconds 2. 45 seconds 3. 43.626 seconds AVERAGE: 44.542 seconds Thanks, Mandar Ambawane