VinayakMarraiya230920 commented on code in PR #360: URL: https://github.com/apache/atlas/pull/360#discussion_r2105250204
########## addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java: ########## @@ -711,6 +711,9 @@ private AtlasEntityWithExtInfo toTableEntity(AtlasEntity database, Table hiveTab private AtlasEntityWithExtInfo toTableEntity(AtlasEntity database, final Table hiveTable, AtlasEntityWithExtInfo table) throws AtlasHookException { if (table == null) { table = new AtlasEntityWithExtInfo(new AtlasEntity(HiveDataTypes.HIVE_TABLE.getName())); + } else if (table.getEntity().getAttribute(ATTRIBUTE_NAME) == null) { + table.getEntity().setAttribute(ATTRIBUTE_NAME, hiveTable.getTableName().toLowerCase()); + table.getEntity().setIsIncomplete(false); Review Comment: When Hive tables are created, Atlas might temporarily create shell entities—incomplete If these shell entities are included in the export file before they are fully resolved, the import will fail with an error like: ERROR - Invalid instance creation/updation parameters passed: hive_table.name: mandatory However, when we run import-hive in Atlas, it completes these shell entities by setting isInComplete = false and filling in the missing details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org