mneethiraj commented on code in PR #360:
URL: https://github.com/apache/atlas/pull/360#discussion_r2109453452
##########
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java:
##########
@@ -711,6 +711,9 @@ private AtlasEntityWithExtInfo toTableEntity(AtlasEntity
database, Table hiveTab
private AtlasEntityWithExtInfo toTableEntity(AtlasEntity database, final
Table hiveTable, AtlasEntityWithExtInfo table) throws AtlasHookException {
if (table == null) {
table = new AtlasEntityWithExtInfo(new
AtlasEntity(HiveDataTypes.HIVE_TABLE.getName()));
+ } else if (table.getEntity().getAttribute(ATTRIBUTE_NAME) == null) {
+ table.getEntity().setAttribute(ATTRIBUTE_NAME,
hiveTable.getTableName().toLowerCase());
+ table.getEntity().setIsIncomplete(false);
Review Comment:
ok. Shouldn't `isIncomplete` be set to `false` for all tables being
imported, i.e. not just for the tables that don't have attribute `name`?
Consider moving line 716 outside the if/else block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
