mneethiraj commented on code in PR #377:
URL: https://github.com/apache/atlas/pull/377#discussion_r2280215645
##########
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java:
##########
@@ -698,7 +701,7 @@ private void traverseImpactedVertices(final AtlasVertex
entityVertexStart, final
Iterable<AtlasEdge> propagationEdges =
entityVertex.getEdges(AtlasEdgeDirection.BOTH, tagPropagationEdges);
for (AtlasEdge propagationEdge : propagationEdges) {
- if (getEdgeStatus(propagationEdge) != ACTIVE) {
+ if (getEdgeStatus(propagationEdge) != ACTIVE &&
!deferredActionEnabled && !RequestContext.get().isImportInProgress()) {
Review Comment:
@chaitalicod - with addition of `&& !deferredActionEnabled` here, tags from
deleted entities will be propagated even when import is not in progress. Note
that the default value of `AtlasConfiguration.TASKS_USE_ENABLED` is true, which
will result in the `if` at line 704 evaluate to `false`, hence will continue
with propagation. This does not look correct. Can you please validate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
