mneethiraj commented on code in PR #377:
URL: https://github.com/apache/atlas/pull/377#discussion_r2283705128


##########
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java:
##########
@@ -698,7 +701,7 @@ private void traverseImpactedVertices(final AtlasVertex 
entityVertexStart, final
             Iterable<AtlasEdge> propagationEdges = 
entityVertex.getEdges(AtlasEdgeDirection.BOTH, tagPropagationEdges);
 
             for (AtlasEdge propagationEdge : propagationEdges) {
-                if (getEdgeStatus(propagationEdge) != ACTIVE) {
+                if (getEdgeStatus(propagationEdge) != ACTIVE && 
!deferredActionEnabled && !RequestContext.get().isImportInProgress()) {

Review Comment:
   @chaitalicod  - when `deferredActionEnabled` is `true`, this `if` condition 
will evaluate to false, hence will continue to propagate classification - even 
when `getEdgeStatus(propagationEdge)` is not `ACTIVE` i.e. deleted edge. This 
doesn't seem correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to