pawarprasad123 commented on code in PR #688:
URL: https://github.com/apache/atlas/pull/688#discussion_r3757107977
##########
dashboard/src/views/SideBar/SideBarTree/SideBarTree.tsx:
##########
@@ -76,24 +76,46 @@ import AddUpdateGlossaryForm from
"@views/Glossary/AddUpdateGlossaryForm";
import RefreshIcon from "@mui/icons-material/Refresh";
import { AntSwitch } from "@utils/Muiutils";
import { IconButton } from "@components/muiComponents";
-import SkeletonLoader from "@components/SkeletonLoader";
+
Review Comment:
Missing deps in useEffect (getNodeId, location.pathname)
Unnecessary searchTerm dependency in another useEffect
##########
dashboard/src/components/GlobalSearch/QuickSearch.tsx:
##########
Review Comment:
DisplayImageProps was tightened from any to Record<string, any>, which
breaks a caller in QuickSearch.tsx:
Even with !isEmpty(entityObj), TypeScript does not narrow entityObj away
from null. Fix options:
Widen the prop: entity: Record<string, any> | null
Add a non-null guard before rendering <DisplayImage />
Use optional chaining with a fallback empty object
This must be fixed before merge if CI runs build:check or typecheck
##########
dashboard/src/components/__tests__/EntityDisplayImage.test.tsx:
##########
@@ -15,271 +15,100 @@
* limitations under the License.
*/
Review Comment:
Add the standard Apache license header (HTML comment format) to each new
SVG, matching atlas_logo.svg.
7 new SVGs missing ASF license header
##########
dashboard/src/components/__tests__/EntityDisplayImage.test.tsx:
##########
@@ -15,271 +15,100 @@
* limitations under the License.
*/
Review Comment:
npm run build passes; npm run build:check / typecheck fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
