Brijesh619 commented on code in PR #688:
URL: https://github.com/apache/atlas/pull/688#discussion_r3760171990
##########
dashboard/src/components/__tests__/EntityDisplayImage.test.tsx:
##########
@@ -15,271 +15,100 @@
* limitations under the License.
*/
Review Comment:
Resolved! The npm run typecheck failure was caused by passing an unknown
type to the id prop inside EntityDisplayImage.tsx. I fixed this by safely
casting entity.guid as string. The typecheck now completes successfully!
##########
dashboard/src/components/__tests__/EntityDisplayImage.test.tsx:
##########
@@ -15,271 +15,100 @@
* limitations under the License.
*/
Review Comment:
Resolved! Added the standard Apache Software Foundation license header
(using the HTML comment format) to all 7 of the new sidebar icon SVG files to
match the existing formatting in `atlas_logo.svg`.
##########
dashboard/src/views/SideBar/SideBarTree/SideBarTree.tsx:
##########
@@ -76,24 +76,46 @@ import AddUpdateGlossaryForm from
"@views/Glossary/AddUpdateGlossaryForm";
import RefreshIcon from "@mui/icons-material/Refresh";
import { AntSwitch } from "@utils/Muiutils";
import { IconButton } from "@components/muiComponents";
-import SkeletonLoader from "@components/SkeletonLoader";
+
Review Comment:
Resolved!
1. I wrapped `getNodeId` in a `useCallback` hook (with `treeName` as its
dependency) so its reference remains stable across renders, and added both
`getNodeId` and `location.pathname` to the dependency array of the main route
synchronization `useEffect`.
2. I removed the unnecessary `searchTerm` dependency from the `useEffect`
inside `TreeLabelWithTooltip` since we only need to re-measure the overflow
threshold when the `label` itself changes.
##########
dashboard/src/components/GlobalSearch/QuickSearch.tsx:
##########
Review Comment:
Resolved! I went with the fallback empty object approach. I updated the
component to pass entity={entityObj || {}}, which successfully resolves the
TypeScript narrowing issue while keeping the tighter type definition intact on
DisplayImageProps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
