> On May 17, 2016, 5:58 a.m., Shwetha GS wrote: > > While addressing the comments, can you also re-base the patch to trunk. > > Sorry about that. Will review as soon as the patch is updated and will > > close it soon
Thanks Shwetha for the review. I have started addressing the review comments. Will update the review board once I am done with the changes. - venkata ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46330/#review133497 ----------------------------------------------------------- On April 28, 2016, 12:59 p.m., venkata madugundu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46330/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 12:59 p.m.) > > > Review request for atlas, David Kantor and Hemanth Yamijala. > > > Bugs: ATLAS-683 > https://issues.apache.org/jira/browse/ATLAS-683 > > > Repository: atlas > > > Description > ------- > > The local type-cache has been carved out as an interface ITypeCacheProvider > and the TypeSystem code has been refactored to use an instance of > ITypeCacheProvider injected through Guice. An instance of ITypeCacheProvider > is created by looking up the implementation class specified in > atlas-application.properties (property - atlas.typesystem.cache.provider). > The default implementation is a local cache implemented by > DefaultTypeCacheProvider. > > > Diffs > ----- > > .gitignore ff7c32e9280a2b1fdafc99fe8113c4d82452318e > common/src/main/java/org/apache/atlas/AtlasRuntimeException.java > PRE-CREATION > distro/src/conf/atlas-application.properties > 290105f2374c3c2e7fadf601d26993081e344974 > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > 8dae9686d0cb698577e6028758ae8eb682823995 > repository/src/test/java/org/apache/atlas/repository/BaseTest.java > 7e1df676c1502d14df2af4fc90513009fdafc632 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > ae215f99080047c6fe45b55ae0c5ad7c1ba600e2 > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > 961442bbcaff86b472a876e6c348aa9e65c1efca > repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala > b23c0f60ace59fa15886c94f35e35d3113872783 > repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala > 0e0ac8633a256dc7c8966c2b8d52eb942b52e1c6 > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > 7763ebc39593d2ba747bd53e861f1d35657c8ea1 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java > 4e1cd36bc1ccf6e770bca3d649b9203dbbc179a8 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java > PRE-CREATION > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java > PRE-CREATION > typesystem/src/test/java/org/apache/atlas/typesystem/types/BaseTest.java > 64dc7511a756f8f68519b48a38228696a866a7f8 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/HierarchicalTypeDependencySorterTest.java > 19bdccfc6baf503f3144fce8fe0b85914693d054 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeInheritanceTest.java > c13ef3a10d7efa2c6a8fa6c261a3402d633f08d4 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java > PRE-CREATION > > typesystem/src/test/scala/org/apache/atlas/typesystem/builders/BuilderTest.scala > 9d1d00f1dc649101119a3eebfca72e9bb3378a3d > > typesystem/src/test/scala/org/apache/atlas/typesystem/builders/MultiplicityTest.scala > 91e72c7d78e44d65f8fe8e2516d38c0da00ddd00 > > typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala > 98a97398cfc232a985e7dc7c83c57f00791c3cdb > > Diff: https://reviews.apache.org/r/46330/diff/ > > > Testing > ------- > > Unit tests for the local cache DefaultTypeCacheProvider have been authored > and all other affected unit tests of TypeSystem interface are modified to > function in the presence of a type cache provider. Ran all tests of Atlas. > > > Thanks, > > venkata madugundu > >
