> On May 18, 2016, 4:29 p.m., Shwetha GS wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java, > > line 162 > > <https://reviews.apache.org/r/46330/diff/5/?file=1385500#file1385500line162> > > > > Sorry I missed this earlier. Shouldn't the write to type store happen > > here? > > venkata madugundu wrote: > Previously, types were cached in a map that was owned by TypeSystem. Now > that map has been replaced with an ITypeCacheProvider instance, which > TypeSystem delegates to for all type cache related operations. Here we are > in DefaultTypeCacheProvider implementation of ITypeCacheProvider, which is > caching the types in a local HashMap just like TypeSystem used to do. So no, > this is not where a type store write should happen.
For the interface get(typecategory, name), you mentioned that types can be partitioned by type category, I thought you meant the type store. If you meant, partitioning in the cache, this is fine - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46330/#review133761 ----------------------------------------------------------- On May 17, 2016, 2:55 p.m., venkata madugundu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46330/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 2:55 p.m.) > > > Review request for atlas, David Kantor and Hemanth Yamijala. > > > Bugs: ATLAS-683 > https://issues.apache.org/jira/browse/ATLAS-683 > > > Repository: atlas > > > Description > ------- > > The local type-cache has been carved out as an interface ITypeCacheProvider > and the TypeSystem code has been refactored to use an instance of > ITypeCacheProvider injected through Guice. An instance of ITypeCacheProvider > is created by looking up the implementation class specified in > atlas-application.properties (property - atlas.typesystem.cache.provider). > The default implementation is a local cache implemented by > DefaultTypeCacheProvider. > > > Diffs > ----- > > .gitignore f5899e2069d29d71378cabe51900c120db19eef9 > common/src/main/java/org/apache/atlas/AtlasRuntimeException.java > PRE-CREATION > distro/src/conf/atlas-application.properties > 68a002115bdda99fba4dcace5ab97399c59289d9 > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > 7763ebc39593d2ba747bd53e861f1d35657c8ea1 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java > PRE-CREATION > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java > PRE-CREATION > > typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46330/diff/ > > > Testing > ------- > > Unit tests for the local cache DefaultTypeCacheProvider have been authored > and all other affected unit tests of TypeSystem interface are modified to > function in the presence of a type cache provider. Ran all tests of Atlas. > > > Thanks, > > venkata madugundu > >
