----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review147940 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 296) <https://reviews.apache.org/r/51660/#comment215245> Is it necessary to create ImmutableList for the values in the argument? Please review. repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 303) <https://reviews.apache.org/r/51660/#comment215247> if keywordCache is empty, none of the following for(..) loops are necessary. Consider moving these for(..) loops inside a if(keywordCacheNotEmpty() { } block. repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 306) <https://reviews.apache.org/r/51660/#comment215250> Check if enumDefs is null before using in for(..). Please review and update other such usage here. repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 308) <https://reviews.apache.org/r/51660/#comment215249> It will help to add the keyword in the exception message; like: throw new AtlasException("Enum definition name is a keyword: " + enumDef.name); Please review and update other exception messages here. - Madhan Neethiraj On Sept. 6, 2016, 10:07 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51660/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 10:07 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and > Vimal Sharma. > > > Repository: atlas > > > Description > ------- > > [ATLAS-1098] Added keyword checks while creating a new tag/trait > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 4d05d49 > > Diff: https://reviews.apache.org/r/51660/diff/ > > > Testing > ------- > > Tested with all possible keywords specified in the QueryParser, the UI shows > a red exception message stating that the type being created is a keyword > > > Thanks, > > Apoorv Naik > >
