----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/#review148465 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (lines 246 - 247) <https://reviews.apache.org/r/51660/#comment215918> Can you also add tests for this? repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 295) <https://reviews.apache.org/r/51660/#comment215917> TypeSystem.verifyTypes() has all the validations. Please move this logic there. - Shwetha GS On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51660/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 11:27 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and > Vimal Sharma. > > > Repository: atlas > > > Description > ------- > > [ATLAS-1098] Added keyword checks while creating a new tag/trait > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 4d05d49 > > Diff: https://reviews.apache.org/r/51660/diff/ > > > Testing > ------- > > Tested with all possible keywords specified in the QueryParser, the UI shows > a red exception message stating that the type being created is a keyword > > > Thanks, > > Apoorv Naik > >