----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51660/ -----------------------------------------------------------
(Updated Sept. 16, 2016, 10:51 p.m.) Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and Vimal Sharma. Changes ------- Updated patch with Unit test fix Repository: atlas Description ------- [ATLAS-1098] Added keyword checks while creating a new tag/trait Diffs (updated) ----- repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 6a937f4 repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 4d2429e repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 01c4bfa repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 8a40110 repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 52dcfde Diff: https://reviews.apache.org/r/51660/diff/ Testing (updated) ------- Tested with all possible keywords specified in the QueryParser, the UI loads up the trait definition. UnitTests create the traitDef and the dsl search gives results Thanks, Apoorv Naik
