----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58724/#review173026 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java Lines 467 (patched) <https://reviews.apache.org/r/58724/#comment246107> "newClassification" may not have all attributes. Consider adding validateAndNormalizeForUpdate(AtlasClassification), similar to the one for entity. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java Lines 480 (patched) <https://reviews.apache.org/r/58724/#comment246109> "newClassifications" may not have all attributes, it might only have the updated attributes. If "newClassifications" argument is used in "onClassificationAddedToEntity()", please update to send classificaions with all attributes. - Madhan Neethiraj On April 25, 2017, 11:53 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58724/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 11:53 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1751 > https://issues.apache.org/jira/browse/ATLAS-1751 > > > Repository: atlas > > > Description > ------- > > Current REST implementation for classification supports only create and > delete classification associated with entities. This JIRA addresses update to > multiple classification attributes associated with entities. > > > Diffs > ----- > > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7b1f2ad7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > c256ae20 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 27f6928a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 9d11aa5d > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 362fb67e > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > 3161a0da > > > Diff: https://reviews.apache.org/r/58724/diff/1/ > > > Testing > ------- > > mvn clean install with known failures > > Added unit tests. > > > Thanks, > > Sarath Subramanian > >
